chore(ci): include fixtures for all previous forks in eest releases #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
changed the title
danceratopz
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Makes sense - LGTM!
I added a changelog entry, we shouldn't forget to mention this in the release notes, even if it's not strictly a breaking change.
This will (slightly) impact hive instances upon the next release, so I created a PR for the devnet-5 hive config that would maintain the current behaviour:
skylenet
pushed a commit
to ethpandaops/pectra-devnets
that referenced
this pull request
Jan 23, 2025
This PR shouldn't change the current behavior as [pectra-devnet-5@v1.2.0](https://github.com/ethereum/execution-spec-tests/releases/tag/pectra-devnet-5%40v1.2.0) only contains tests filled for `Prague` and the `CancunToPragueAt15k` transition. It does, however, ensure the current behavior is maintained for this hive instance for upcoming EEST releases that contain tests filled for previously deployed forks, which will be the case when this PR gets merged: - ethereum/execution-spec-tests#1053 Feel free to disregard this PR, as running tests for all forks might be desirable 😆 here's what the impact would currently be: - Prague-only: 4062 tests. - Until Prague: 6525 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
--untilinstead of--fork, to include filled tests for legacy forks too.legacyfeature is now removed sincestablenow includes all forks starting fromFrontier.This issue was raised by some teams who would like to have all tests in the same package for their QA procedures.
🔗 Related Issues
None
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.